stream: fix recursive WritableStream abort - #64825
Open
standard-Chan wants to merge 1 commit into
Open
Conversation
Recheck the stream state after signaling abort, as required by steps 3 and 4 of the WritableStreamAbort algorithm. Only reject pending close promise caches, as a cache materialized after the stream becomes errored may already contain a rejected promise. This makes the recursive abort WPT pass and removes its expected-failure entry. Refs: https://streams.spec.whatwg.org/#writable-stream-abort Signed-off-by: Jeong SeokChan <starp321@naver.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64825 +/- ##
=======================================
Coverage 90.14% 90.15%
=======================================
Files 746 746
Lines 242818 242821 +3
Branches 45765 45765
=======================================
+ Hits 218884 218904 +20
- Misses 15417 15419 +2
+ Partials 8517 8498 -19
🚀 New features to boost your workflow:
|
Author
|
The build-tarball job was canceled because exceeding the 15-minute execution limit. Could someone please rerun the failed job? |
daeyeon
approved these changes
Aug 1, 2026
daeyeon
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-check the stream state after signaling the controller's abort signal, as required by steps 3 and 4 of the
WritableStreamAbortalgorithm.Refs: https://streams.spec.whatwg.org/#writable-stream-abort
Also, reject close promise caches only when their promises are still pending. A cache lazily materialized after the stream becomes errored may already contain a rejected promise and does not have a callable
rejectmethod.Remove the expected-failure entry for the recursive abort WPT.
Testing